Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/lie/basic): define missing inclusion maps #5207

Closed
wants to merge 4 commits into from

Conversation

ocfnash
Copy link
Collaborator

@ocfnash ocfnash commented Dec 3, 2020


I am attempting to get to the definition of a solvable Lie algebra. I'm pretty sure these were the last missing pieces.

@ocfnash ocfnash added the awaiting-review The author would like community review of the PR label Dec 3, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nitpick about names.

Looking forward to solvable Lie algs!!

src/algebra/lie/basic.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors d+

src/algebra/lie/basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Dec 3, 2020

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 3, 2020
Co-authored-by: Johan Commelin <johan@commelin.net>
@ocfnash
Copy link
Collaborator Author

ocfnash commented Dec 3, 2020

bors merge

@bors
Copy link

bors bot commented Dec 4, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/lie/basic): define missing inclusion maps [Merged by Bors] - feat(algebra/lie/basic): define missing inclusion maps Dec 4, 2020
@bors bors bot closed this Dec 4, 2020
@bors bors bot deleted the lie_inclusions branch December 4, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants