[Merged by Bors] - refactor(data/finsupp/basic): merge finsupp.of_multiset and multiset.to_finsupp
#5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other changes: * use proper section headers; * move `add_monoid` section above `card`; * fix docstrings of `multiset.choose_x` and `multiset.choose`.
urkud
added
awaiting-review
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
urkud
removed
the
blocked-by-other-PR
2 tasks
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 10, 2020
…et.to_finsupp` (#5237) * redefine `finsupp.to_multiset` as an `add_equiv`; * drop `finsupp.equiv_multiset` and `finsupp.of_multiset`; * define `multiset.to_finsupp` as `finsupp.to_multiset.symm`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
finsupp.of_multiset and multiset.to_finsuppfinsupp.of_multiset and multiset.to_finsupp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finsupp.to_multisetas anadd_equiv;finsupp.equiv_multisetandfinsupp.of_multiset;multiset.to_finsuppasfinsupp.to_multiset.symm.carda bundledadd_monoid_hom#5228 makemultiset.cardanadd_monoid_hommap_powetc as@[simp]#5253 simplifyf (x^n) = f x ^ n