New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ring_theory/ideals): lift for quotient rings #529

Merged

digama0 merged 1 commit into leanprover-community:master from leanprover-fork:ideal_lift

Dec 21, 2018

Member

ChrisHughes24 commented Dec 19, 2018 •

edited

#528 depends on this PR. lift for quotient rings. Also definition of coprime and a couple of lemmas

TO CONTRIBUTORS:

Make sure you have:

reviewed and applied the coding style: coding, naming
for tactics:
- added or adapted documentation in tactics.md
- write an example of use of the new feature in tactics.lean
make sure definitions and lemmas are put in the right files
make sure definitions and lemmas are not redundant

For reviewers: code review check list


          feat(ring_theory/ideals): lift for quotient rings

c8e43b1

Member

jcommelin commented Dec 20, 2018

You're not only doing lift. You're also sneaking in some lemmas about coprime.

digama0 merged commit 3762d96 into leanprover-community:master

ChrisHughes24 deleted the ideal_lift branch

December 21, 2018 08:48

cipher1024 pushed a commit that referenced this pull request


          feat(ring_theory/ideals): lift for quotient rings (#529)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment