Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(analysis/analytic/basic): redefine formal_multilinear_series.radius #5349

Closed
wants to merge 33 commits into from
Closed

[Merged by Bors] - refactor(analysis/analytic/basic): redefine formal_multilinear_series.radius #5349

wants to merge 33 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 13, 2020 •
edited by github-actions bot

@urkud
chore(analysis/calculus): move the definition of `formal_multilinear_…
9d83de1 
…series` to a new file
@urkud
Long line
3262bae
@urkud
refactor(analysis/analytic/basic): redefine `formal_multilinear_serie…
244409a 
…s.radius`

With the new definition, (a) some proofs get much shorter; (b) we
don't need `rpow` in `analytic/basic`.
@urkud urkud added the awaiting-review The author would like community review of the PR label Dec 13, 2020
@urkud urkud requested a review from sgouezel December 13, 2020 07:22
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 13, 2020
@sgouezel
Copy link
Collaborator

Thanks, this is something that had to be done to redefine the exponential using power series while avoiding loops. Still, could you prove that the new definition equals the liminf definition of the convergence radius, in another file, as this definition can be handy sometimes?

@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Dec 13, 2020
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 14, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 22, 2020
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 25, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 26, 2020
@urkud urkud added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. needs-documentation This PR is missing required documentation and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 30, 2020
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 30, 2020
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@urkud urkud removed the needs-documentation This PR is missing required documentation label Dec 30, 2020
sgouezel
sgouezel reviewed Dec 31, 2020
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
bors d+

src/analysis/specific_limits.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Dec 31, 2020

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 31, 2020
@urkud
Copy link
Member Author

urkud commented Dec 31, 2020

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 31, 2020
bors bot pushed a commit that referenced this pull request Dec 31, 2020
@urkud
refactor(analysis/analytic/basic): redefine `formal_multilinear_serie…
0830bfd 
…s.radius` (#5349)

With the new definition, (a) some proofs get much shorter; (b) we
don't need `rpow` in `analytic/basic`.
@bors
Copy link

bors bot commented Dec 31, 2020

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@bors bors bot changed the title refactor(analysis/analytic/basic): redefine formal_multilinear_series.radius [Merged by Bors] - refactor(analysis/analytic/basic): redefine formal_multilinear_series.radius Dec 31, 2020
@bors bors bot closed this Dec 31, 2020
@bors bors bot deleted the redefine-conv-radius branch December 31, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @sgouezel @bryangingechen