Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/mean_inequalities): add Minkowski's inequality for the Lebesgue integral of ennreal functions #5379

Closed
wants to merge 12 commits into from

Conversation

RemyDegenne
Copy link
Collaborator


I am not happy with the private lemma named minkowski_aux but it proves something so specific and unlikely to be used elsewhere that I opted for not giving it a descriptive (and convoluted) name.

@RemyDegenne RemyDegenne added the awaiting-review The author would like community review of the PR label Dec 15, 2020
@RemyDegenne RemyDegenne changed the title feat(analysis/mean_inequalities): add minkowski's inequality for the Lebesgue integral of ennreal functions feat(analysis/mean_inequalities): add Minkowski's inequality for the Lebesgue integral of ennreal functions Dec 15, 2020
@sgouezel
Copy link
Collaborator

sgouezel commented Dec 15, 2020

I am not so sure that the lemma should be private, you never know what might be handy later on. A name like lintegral_mul_rpow_le_lintegral_rpow_mul_lintegral_rpow would be fine for me. On the other hand, I wouldn't mind at all if you make the lemma lintegral_rpow_add_le_add_lintegral_rpow_of_lintegral_add_ne_zero_ne_top private and replaced its name with lintegral_rpow_add_le_add_lintegral_rpow_aux: the assumptions of this lemma are strictly stronger than the ones in lintegral_rpow_add_le_add_lintegral_rpow, so there is no situation where it could be useful later on.

Also, the name for finite sums is Lp_add_le, which is both short and to the point. What about finding a short name also for the integral version? I think I would even advocate Lp_add_le for the integral version, and Lp_sum_add_le for the finite version. Except that other versions are coming, so maybe lintegral_Lp_add_le for the current integral version?

@RemyDegenne
Copy link
Collaborator Author

RemyDegenne commented Dec 15, 2020

I changed the names and private status:

  • the lemma that was private isn't anymore, and is now called lintegral_mul_rpow_le_lintegral_rpow_mul_lintegral_rpow.
  • the lemma that proves Minkowski's inequality under stronger assumptions is now private, and called lintegral_Lp_add_le_aux,
  • Minkowski's inequality is now lintegral_Lp_add_le

@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 15, 2020
bors bot pushed a commit that referenced this pull request Dec 15, 2020
@bors
Copy link

bors bot commented Dec 15, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/mean_inequalities): add Minkowski's inequality for the Lebesgue integral of ennreal functions [Merged by Bors] - feat(analysis/mean_inequalities): add Minkowski's inequality for the Lebesgue integral of ennreal functions Dec 15, 2020
@bors bors bot closed this Dec 15, 2020
@bors bors bot deleted the minkowski_lintegral branch December 15, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants