[Merged by Bors] - chore(analysis/calculus/deriv): add iff versions of differentiable_const_add etc
#5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_const_add` etc Also drop some unneeded `differentiable` assumptions in lemmas like `deriv_const_add`.
sgouezel
reviewed
Dec 16, 2020
There was a problem hiding this comment.
I'm really happy when useless assumptions are removed, you just made my day :-)
My only question is about names: you have lemmas like differentiable_within_at_neg_iff and differentiable_within_at_sub_const, which are really comparable except that one has iff in its name and the other doesn't. I don't have a strong preference for one or the other (maybe I prefer slightly with the iff because the addition is short, and it removes a very small ambiguity), but what I'd really like to have is coherence.
sgouezel
added
awaiting-author
bryangingechen
added
awaiting-review
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 17, 2020
…_const_add` etc (#5390) Also drop some unneeded `differentiable` assumptions in lemmas like `deriv_const_add`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
iff versions of differentiable_const_add etciff versions of differentiable_const_add etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also drop some unneeded
differentiableassumptions in lemmas likederiv_const_add.