Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(tactic/field_simp): let field_simp use norm_num to prove numerals are nonzero #5418
[Merged by Bors] - feat(tactic/field_simp): let field_simp use norm_num to prove numerals are nonzero #5418
Changes from 7 commits
5c1182e
6defa9f
33ca870
7cceffe
6d7ff85
a359181
fe55e8f
e21efff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you've changed the discharger from the default
simp
, this claim about products and powers is no longer true, right? The only preconditions you'll solve are those that are literally in the context and numeric ones.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it. The default discharger for
simp
isfailed
, right? So it's only making things more powerful. Indeed, with the modification it solves everything it solved previously (at least all the mathlib examples and tests).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, I take it back. Seems like the
discharger
option is used in addition to recursively callingsimp
. I thought it was replacing that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh.
field_simp
isn'tsimp only using field_simps
, it uses the full simp set. I didn't realize this. So technically nonterminalfield_simp
is a bad idea, although I guess it's less likely to be abused than regularsimp
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there are places in the library where it's used as:
simp
+ the additional ability to simplify denominators. Just like simp, it shouldn't be used non-terminally, but in general it is justfield_simp [...], ring
.