Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory): connected components of a category #5425

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat(category_theory): connected components of a category #5425

wants to merge 12 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Dec 18, 2020 •
edited by github-actions bot

@b-mehta b-mehta added the WIP Work in progress label Dec 18, 2020
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 19, 2020
@b-mehta b-mehta added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Dec 19, 2020
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jan 6, 2021
@github-actions
Copy link

github-actions bot commented Jan 6, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 6, 2021
@jcommelin jcommelin self-assigned this Jan 16, 2021
jcommelin
jcommelin reviewed Jan 16, 2021
View reviewed changes
src/category_theory/connected_components.lean Outdated Show resolved Hide resolved
src/category_theory/connected_components.lean
category structure.
This category is equivalent to `J`.
-/
abbreviation decomposed (J : Type u₁) [category.{v₁} J] :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name seems somewhat generic, and it's in the category_theory namespace.
Same holds for inclusion below it, which is even more generic, maybe.

Maybe they should be namespaced?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea - or just picking a more descriptive name for these. Do you have suggestions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't really come up with a good name for this one... you could ask on Zulip, maybe someone has inspiration

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 16, 2021
@b-mehta b-mehta added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 16, 2021
@bryangingechen
Copy link
Collaborator

Is this PR all good other than the naming question above?

@jcommelin
Copy link
Member

Yes, sorry, I lost track of this PR. It adds category_theory.decomposed. Maybe I made it a bigger problem than it is. It's not clashing with established terminology.

@b-mehta If you want to change it, go ahead. Otherwise, let's just merge this. Thanks for the PR!

bors d+

@bors
Copy link

bors bot commented Jan 27, 2021

✌️ b-mehta can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@b-mehta
Copy link
Collaborator Author

b-mehta commented Jan 30, 2021

Oh I forgot about this as well! I feel like the name category_theory.inclusion isn't optimal, so for now I'll add a comment saying we could change the name - that way if a name clash happens in the future this can be changed.

@bryangingechen bryangingechen removed the awaiting-review The author would like community review of the PR label Feb 3, 2021
@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. labels Feb 3, 2021
@bryangingechen
Copy link
Collaborator

@b-mehta ping?

@b-mehta
Copy link
Collaborator Author

b-mehta commented Feb 6, 2021

Oops, I forgot about this too! I've added the comment I mentioned

@b-mehta
Copy link
Collaborator Author

b-mehta commented Feb 6, 2021

bors r+

bors bot pushed a commit that referenced this pull request Feb 6, 2021
@b-mehta
feat(category_theory): connected components of a category (#5425)
7ec4fcc
@bors
Copy link

bors bot commented Feb 6, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory): connected components of a category [Merged by Bors] - feat(category_theory): connected components of a category Feb 6, 2021
@bors bors bot closed this Feb 6, 2021
@bors bors bot deleted the category-connected-components branch February 6, 2021 22:54
b-mehta added a commit that referenced this pull request Apr 2, 2021
@b-mehta
feat(category_theory): connected components of a category (#5425)
80c1442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees

@jcommelin jcommelin

Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@b-mehta @bryangingechen @jcommelin