Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/power_series): define power series for exp, sin, cos, and 1 / (u - x). #5432

Closed
wants to merge 13 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 18, 2020

This PR defines power_series.exp etc to be formal power series for the corresponding functions. Once we have a bridge to is_analytic, we should redefine complex.exp etc using these power series.


Should I move ring_theory/power_series to ring_theory/power_series/basic, and this new file to ring_theory/power_series/SOME_NAME?

@urkud urkud added the awaiting-review The author would like community review of the PR label Dec 18, 2020
@jcommelin
Copy link
Member

Should I move ring_theory/power_series to ring_theory/power_series/basic, and this new file to ring_theory/power_series/SOME_NAME?

Yes, I think this makes sense.

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 21, 2020
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 22, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 22, 2020
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 22, 2020
@urkud urkud changed the title feat(ring_theory/series_defs): define power series for exp, sin, cos, and 1 / (u - x). feat(ring_theory/power_series): define power series for exp, sin, cos, and 1 / (u - x). Dec 22, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 22, 2020
bors bot pushed a commit that referenced this pull request Dec 22, 2020
… `cos`, and `1 / (u - x)`. (#5432)

This PR defines `power_series.exp` etc to be formal power series for the corresponding functions. Once we have a bridge to `is_analytic`, we should redefine `complex.exp` etc using these power series.
@bors
Copy link

bors bot commented Dec 22, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/power_series): define power series for exp, sin, cos, and 1 / (u - x). [Merged by Bors] - feat(ring_theory/power_series): define power series for exp, sin, cos, and 1 / (u - x). Dec 22, 2020
@bors bors bot closed this Dec 22, 2020
@bors bors bot deleted the series-defs branch December 22, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants