New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(ring_theory/power_series): define power series for exp
, sin
, cos
, and 1 / (u - x)
.
#5432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, I think this makes sense. |
urkud
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Dec 21, 2020
github-actions
bot
added
the
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
label
Dec 22, 2020
github-actions
bot
removed
the
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
label
Dec 22, 2020
urkud
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Dec 22, 2020
urkud
changed the title
feat(ring_theory/series_defs): define power series for
feat(ring_theory/power_series): define power series for Dec 22, 2020
exp
, sin
, cos
, and 1 / (u - x)
.exp
, sin
, cos
, and 1 / (u - x)
.
jcommelin
approved these changes
Dec 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Dec 22, 2020
bors bot
pushed a commit
that referenced
this pull request
Dec 22, 2020
… `cos`, and `1 / (u - x)`. (#5432) This PR defines `power_series.exp` etc to be formal power series for the corresponding functions. Once we have a bridge to `is_analytic`, we should redefine `complex.exp` etc using these power series.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(ring_theory/power_series): define power series for
[Merged by Bors] - feat(ring_theory/power_series): define power series for Dec 22, 2020
exp
, sin
, cos
, and 1 / (u - x)
.exp
, sin
, cos
, and 1 / (u - x)
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines
power_series.exp
etc to be formal power series for the corresponding functions. Once we have a bridge tois_analytic
, we should redefinecomplex.exp
etc using these power series.Should I move
ring_theory/power_series
toring_theory/power_series/basic
, and this new file toring_theory/power_series/SOME_NAME
?