Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/limits): yoneda reflects limits #5447

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(category_theory/limits): yoneda reflects limits #5447

wants to merge 6 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Dec 20, 2020 •
edited by github-actions bot

yoneda and coyoneda jointly reflect limits

@b-mehta b-mehta added the awaiting-review The author would like community review of the PR label Dec 20, 2020
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 20, 2020
kbuzzard
kbuzzard approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/category_theory/limits/yoneda.lean Outdated Show resolved Hide resolved
src/category_theory/limits/yoneda.lean Outdated Show resolved Hide resolved
@b-mehta @kbuzzard
Update src/category_theory/limits/yoneda.lean
fac4356 
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Dec 21, 2020
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 23, 2020
jcommelin
jcommelin reviewed Dec 25, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the let statements mean that [simps] can't be used?

@b-mehta
Copy link
Collaborator Author

b-mehta commented Dec 25, 2020

I don't think so, but moreover is_limit is subsingleton anyway (not just unique up to iso)

@jcommelin
Copy link
Member

Fair enough!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 25, 2020
bors bot pushed a commit that referenced this pull request Dec 25, 2020
@b-mehta
feat(category_theory/limits): yoneda reflects limits (#5447)
d968a61 
yoneda and coyoneda jointly reflect limits
@bors
Copy link

bors bot commented Dec 25, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/limits): yoneda reflects limits [Merged by Bors] - feat(category_theory/limits): yoneda reflects limits Dec 25, 2020
@bors bors bot closed this Dec 25, 2020
@bors bors bot deleted the yoneda-reflect-limits branch December 25, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@kbuzzard kbuzzard kbuzzard approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@b-mehta @jcommelin @kbuzzard