New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (ring_theory/noetherian) various lemmas #548

Merged

digama0 merged 1 commit into leanprover-community:master from leanprover-fork:noetherian

Dec 21, 2018

Collaborator

kckennylau commented Dec 20, 2018

TO CONTRIBUTORS:

Make sure you have:

reviewed and applied the coding style: coding, naming
for tactics:
- added or adapted documentation in tactics.md
- write an example of use of the new feature in tactics.lean
make sure definitions and lemmas are put in the right files
make sure definitions and lemmas are not redundant

For reviewers: code review check list


          feat (ring_theory/noetherian) various lemmas

2c5dd61

Collaborator

semorrison commented Dec 21, 2018

So much maths! This is great.

digama0 merged commit d7cea06 into leanprover-community:master

digama0 deleted the noetherian branch

December 21, 2018 07:35

cipher1024 pushed a commit that referenced this pull request


          feat (ring_theory/noetherian) various lemmas (#548)

7ac639b

kckennylau mentioned this pull request

Hilbert basis theorem and integral closure [WIP] #461

Closed

6 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment