Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(topology/algebra/ordered): move code, add missing lemmas #5481

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - chore(topology/algebra/ordered): move code, add missing lemmas #5481

wants to merge 15 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 22, 2020 •
edited by github-actions bot

  • merge two sections about linear_ordered_add_comm_group;
  • add missing lemmas about limits of f * g when one of f, g tends to -∞, and another tends to a positive or negative constant;
  • drop neg_preimage_closure in favor of the new neg_closure in topology/algebra/group.

@urkud urkud added the awaiting-review The author would like community review of the PR label Dec 22, 2020
@github-actions github-actions bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Dec 22, 2020
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

bryangingechen
bryangingechen approved these changes Dec 30, 2020
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 30, 2020
bors bot pushed a commit that referenced this pull request Dec 30, 2020
@urkud
chore(topology/algebra/ordered): move code, add missing lemmas (#5481)
8545aa6 
* merge two sections about `linear_ordered_add_comm_group`;
* add missing lemmas about limits of `f * g` when one of `f`, `g` tends to `-∞`, and another tends to a positive or negative constant;
* drop `neg_preimage_closure` in favor of the new `neg_closure` in `topology/algebra/group`.
@bors
Copy link

bors bot commented Dec 30, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(topology/algebra/ordered): move code, add missing lemmas [Merged by Bors] - chore(topology/algebra/ordered): move code, add missing lemmas Dec 30, 2020
@bors bors bot closed this Dec 30, 2020
@bors bors bot deleted the at-bot-mul branch December 30, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @bryangingechen