functions and cardinality #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johoelzl
reviewed
Jan 9, 2019
johoelzl
reviewed
Jan 9, 2019
logic/function.lean
Outdated
| @@ -5,7 +5,7 @@ Authors: Johannes Hölzl, Mario Carneiro | |||
|
|
|||
| Miscellaneous function constructions and lemmas. | |||
| -/ | |||
| import logic.basic data.option.defs | |||
| import logic.basic data.option.defs data.set.function | |||
There was a problem hiding this comment.
I'm against importing data (besides any defs) in logic
It's not officially documented, but my mental model is that logic should be mostly independent. (And then logic -> order -> algebra, and only small things are imported from data)
We could move some stuff in data.set... to data.set.defs
There was a problem hiding this comment.
Is it OK if I do the import in the the other direction, i.e., prove stuff on inv_fun_on in data.set.function?
There was a problem hiding this comment.
I did it the other way around, proving stuff in data.set.function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor missing facts from the library