Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(algebra/group/prod): fixes for #5563 #5577

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - fix(algebra/group/prod): fixes for #5563 #5577

wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 2, 2021

  • rename prod.units to mul_equiv.prod_units;
  • rewrite it with better definitional equalities;
  • now @[to_additive] works: fixes to_additive failure in prod.units #5566;
  • make M and N implicit in mul_equiv.prod_comm

@urkud
fix(algebra/group/prod): fixes for #5563
c04888a 
* rename `prod.units` to `mul_equiv.prod_units`;
* rewrite it with better definitional equalities;
* now `@[to_additive]` works: fixes #5566;
* make `M` and `N` implicit in `mul_equiv.prod_comm`
@urkud urkud added the WIP Work in progress label Jan 2, 2021
urkud
urkud commented Jan 3, 2021
View reviewed changes
src/algebra/group/prod.lean Outdated Show resolved Hide resolved
@urkud urkud added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 3, 2021
@kbuzzard
Copy link
Member

kbuzzard commented Jan 3, 2021

Do you know why to_additive did not work originally?

@urkud
Copy link
Member Author

urkud commented Jan 3, 2021

Do you know why to_additive did not work originally?

No. I guess, it tried to add auxiliary definitions about pattern matching in the wrong order.

@sgouezel
Copy link
Collaborator

sgouezel commented Jan 5, 2021

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 5, 2021
bors bot pushed a commit that referenced this pull request Jan 5, 2021
@urkud
fix(algebra/group/prod): fixes for #5563 (#5577)
0c8fffe 
* rename `prod.units` to `mul_equiv.prod_units`;
* rewrite it with better definitional equalities;
* now `@[to_additive]` works: fixes #5566;
* make `M` and `N` implicit in `mul_equiv.prod_comm`
@bors
Copy link

bors bot commented Jan 5, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(algebra/group/prod): fixes for #5563 [Merged by Bors] - fix(algebra/group/prod): fixes for #5563 Jan 5, 2021
@bors bors bot closed this Jan 5, 2021
@bors bors bot deleted the fix-units-prod branch January 5, 2021 23:58
pglutz pushed a commit that referenced this pull request Jan 6, 2021
@urkud @pglutz
fix(algebra/group/prod): fixes for #5563 (#5577)
4d6704e 
* rename `prod.units` to `mul_equiv.prod_units`;
* rewrite it with better definitional equalities;
* now `@[to_additive]` works: fixes #5566;
* make `M` and `N` implicit in `mul_equiv.prod_comm`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_additive failure in prod.units
3 participants
@urkud @kbuzzard @sgouezel