Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(measure_theory/pi): a few more lemmas #5604

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - chore(measure_theory/pi): a few more lemmas #5604

wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 4, 2021 •
edited by github-actions bot

Also prove that a locally finite measure in a second_countable_topology is sigma_finite.

@urkud urkud added the awaiting-review The author would like community review of the PR label Jan 4, 2021
@urkud urkud requested a review from fpvandoorn January 4, 2021 05:27
@github-actions github-actions bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jan 4, 2021
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

fpvandoorn
fpvandoorn reviewed Jan 4, 2021
View reviewed changes
src/algebra/big_operators/order.lean Outdated Show resolved Hide resolved
src/data/real/ennreal.lean Outdated
@@ -748,6 +748,10 @@ section sum

open finset

/-- A product of finite numbers is still finite -/
lemma prod_lt_top {s : finset α} {f : α → ennreal} (h : ∀a∈s, f a < ∞) : (∏ a in s, f a) < ∞ :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that ≠ ∞ was the preferred way to write this in ennreal? But if it's not standard, I'm happy to accept this, and try to uniformize this in a later PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In data/real/ennreal many lemmas are stated both for < ∞ and ≠ ∞. Probably we should uniformize this at some point.

src/measure_theory/measure_space.lean Outdated Show resolved Hide resolved
src/measure_theory/pi.lean Outdated Show resolved Hide resolved
src/measure_theory/pi.lean Outdated Show resolved Hide resolved
urkud
urkud commented Jan 4, 2021
View reviewed changes
src/measure_theory/pi.lean Outdated Show resolved Hide resolved
@urkud @fpvandoorn
Apply suggestions from code review
b80b3e7 
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
@fpvandoorn
Copy link
Member

There is a merge conflict in big_operators/order (presumably with #5602), but other than that this looks good

bors d+

@bors
Copy link

bors bot commented Jan 5, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 5, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 5, 2021
@urkud
Copy link
Member Author

urkud commented Jan 6, 2021

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 6, 2021
bors bot pushed a commit that referenced this pull request Jan 6, 2021
@urkud
chore(measure_theory/pi): a few more lemmas (#5604)
8f424fc 
Also prove that a locally finite measure in a `second_countable_topology` is `sigma_finite`.
@bors
Copy link

bors bot commented Jan 6, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(measure_theory/pi): a few more lemmas [Merged by Bors] - chore(measure_theory/pi): a few more lemmas Jan 6, 2021
@bors bors bot closed this Jan 6, 2021
@bors bors bot deleted the pi-measure branch January 6, 2021 02:29
urkud added a commit that referenced this pull request Jan 6, 2021
@urkud
feat(measure_theory/borel_space): locally finite measure is sigma finite
321390b 
I forgot to add this to #5604
@urkud urkud mentioned this pull request Jan 6, 2021
Closed
pglutz pushed a commit that referenced this pull request Jan 6, 2021
@urkud @pglutz
chore(measure_theory/pi): a few more lemmas (#5604)
fabf483 
Also prove that a locally finite measure in a `second_countable_topology` is `sigma_finite`.
bors bot pushed a commit that referenced this pull request Jan 8, 2021
@urkud
feat(measure_theory/borel_space): locally finite measure is sigma fin…
611bc86 
…ite (#5634)

I forgot to add this to #5604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpvandoorn fpvandoorn fpvandoorn left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @fpvandoorn @bryangingechen