[Merged by Bors] - chore(ring_theory/ideal/basic): Make an argument to mul_mem_{left,right} explicit #5611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These arguments cannot be inferred from any of the other arguments, so it seems ssensible they should be implicit. This allows many uses of `smul_mem` to be replaced with `mul_mem_left`, which is syntactically more convenient as it does not introduce an smul. This also removes the need for some type annotations.
eric-wieser
added
the
awaiting-review
jcommelin
approved these changes
Jan 6, 2021
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 6, 2021
…ht} explicit (#5611) Before this change, the lemmas with result `a * b ∈ I` did not have enough explicit arguments to determine both `a` and `b`, such as `I.mul_mem_left hb`. This resulted in callers using `show`, `@`, or sometimes ignoring the API and using `smul_mem` which does have appropriate argument explicitness. These callers have been cleaned up accordingly.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the lemmas with result
a * b ∈ Idid not have enough explicit arguments to determine bothaandb, such asI.mul_mem_left hb.This resulted in callers using
show,@, or sometimes ignoring the API and usingsmul_memwhich does have appropriate argument explicitness. These callers have been cleaned up accordingly.