Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(computability/language): le on languages #5704

Closed
wants to merge 17 commits into from

Conversation

foxthomson
Copy link
Collaborator

@foxthomson foxthomson commented Jan 11, 2021

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 11, 2021
@foxthomson
Copy link
Collaborator Author

I used set's has_le, will this cause problems later on, I had to use set.le_eq_subset as the first step a bit which felt odd.

src/computability/language.lean Outdated Show resolved Hide resolved
src/computability/language.lean Outdated Show resolved Hide resolved
src/computability/language.lean Outdated Show resolved Hide resolved
src/computability/language.lean Outdated Show resolved Hide resolved
@gebner
Copy link
Member

gebner commented Jan 12, 2021

I used set's has_le, will this cause problems later on, I had to use set.le_eq_subset as the first step a bit which felt odd.

In many cases you don't need to unfold this definition explicitly. Try deleting the rw set.le_eq_subset, most of your proofs still work fine without it.

@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 20, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@bryangingechen bryangingechen added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 20, 2021
Copy link
Member

@gebner gebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

src/computability/language.lean Outdated Show resolved Hide resolved
src/computability/language.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 21, 2021

✌️ foxthomson can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added the delegated The PR author may merge after reviewing final suggestions. label Jan 21, 2021
@foxthomson
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 21, 2021
@bors
Copy link

bors bot commented Jan 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(computability/language): le on languages [Merged by Bors] - feat(computability/language): le on languages Jan 22, 2021
@bors bors bot closed this Jan 22, 2021
@bors bors bot deleted the language-relations branch January 22, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants