[Merged by Bors] - chore(analysis|measure_theory|topology): give tsum notation precedence 67 #5709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e 67 This saves us a lot of `()` In particular, lean no longer thinks that `∑' i, f i = 37` is a tsum of propositions.
jcommelin
added
the
awaiting-review
| @@ -56,7 +56,8 @@ def summable (f : β → α) : Prop := ∃a, has_sum f a | |||
| /-- `∑' i, f i` is the sum of `f` it exists, or 0 otherwise -/ | |||
| @[irreducible] def tsum {β} (f : β → α) := if h : summable f then classical.some h else 0 | |||
|
|
|||
| notation `∑'` binders `, ` r:(scoped f, tsum f) := r | |||
| -- See the comment on precedence of big operators in `algebra/big_operators/basic.lean`. | |||
There was a problem hiding this comment.
Is it worth upgrading that comment to a library note?
Otherwise LGTM.
bors d+
|
✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with |
bryangingechen
added
delegated
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 12, 2021
…e 67 (#5709) This saves us a lot of `()` In particular, lean no longer thinks that `∑' i, f i = 37` is a tsum of propositions.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Jan 16, 2021
…e 67 (#5709) This saves us a lot of `()` In particular, lean no longer thinks that `∑' i, f i = 37` is a tsum of propositions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves us a lot of
()In particular, lean no longer thinks that
∑' i, f i = 37is a tsum of propositions.