Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(data/equiv/basic): swap symm and trans simp lemmas #5738

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(data/equiv/basic): swap symm and trans simp lemmas #5738

wants to merge 1 commit into from

Conversation

pechersky
Copy link
Collaborator

@pechersky pechersky commented Jan 14, 2021 •
edited

Co-authored-by: Eric Wieser wieser.eric@gmail.com

Stubbed out from #5593

@pechersky pechersky added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jan 14, 2021
@pechersky pechersky mentioned this pull request Jan 14, 2021
Closed
10 tasks
eric-wieser
eric-wieser approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's tempting to have the result of swap_self be 1, but I don't think it matters much, and is awkward to change right now. Something for future, perhaps

@gebner
Copy link
Member

gebner commented Jan 14, 2021

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 14, 2021
bors bot pushed a commit that referenced this pull request Jan 14, 2021
@pechersky @eric-wieser
chore(data/equiv/basic): swap symm and trans simp lemmas (#5738)
e3cc92e 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Jan 14, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/equiv/basic): swap symm and trans simp lemmas [Merged by Bors] - chore(data/equiv/basic): swap symm and trans simp lemmas Jan 14, 2021
@bors bors bot closed this Jan 14, 2021
@bors bors bot deleted the pechersky/equiv-basic-swap-simp branch January 14, 2021 19:05
b-mehta pushed a commit that referenced this pull request Jan 16, 2021
@pechersky @eric-wieser @b-mehta
chore(data/equiv/basic): swap symm and trans simp lemmas (#5738)
bcf8f40 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pechersky @gebner @eric-wieser