Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(order/limsup_liminf, order/filter/ennreal): add properties of limsup for ennreal-valued functions #5746

Closed
wants to merge 29 commits into from

Conversation

RemyDegenne
Copy link
Collaborator

@RemyDegenne RemyDegenne commented Jan 14, 2021


@RemyDegenne RemyDegenne added the awaiting-review The author would like community review of the PR label Jan 14, 2021
@sgouezel
Copy link
Collaborator

I wonder if we could use a slightly more abstract definition to deduce many properties from things we already have on limsups: the essential supremum of a function is the limsup of this function along the almost-everywhere filter, I think.

@RemyDegenne
Copy link
Collaborator Author

RemyDegenne commented Jan 14, 2021

I just looked at filter.limsup, and indeed it is very very close to what I defined. The lemma filter.limsup_eq even states f.limsup u = Inf {a : α | ∀ᶠ (n : β) in f, u n ≤ a}

I spent some time looking at existing definitions before writing the new code but I missed that one.

@RemyDegenne RemyDegenne added awaiting-author A reviewer has asked the author a question or requested changes WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Jan 14, 2021
@RemyDegenne
Copy link
Collaborator Author

I am thinking about removing the ess_sup/ess_inf definitions entirely, as well as the ess_sup file. It looks like all the ess_sup lemmas do at the moment is translate an hypothesis µ \ne 0 into µ.ae.ne_bot when necessary, then call a limsup lemma.

I don't know where I should put the ennreal results. data/real/ennreal does not import filters and topology/instances/ennreal does not seem to be the right place either. Should I create an order/instances/ennreal file?

I tried generalizing the results beyond ennreal for a bit, but it looks like I would need new and very specific classes (something like a (conditionally?)_complete_canonically_linear_ordered_cancel_add_comm_monoid), so I'll keep ennreal.

@RemyDegenne RemyDegenne removed the awaiting-author A reviewer has asked the author a question or requested changes label Jan 15, 2021
@RemyDegenne
Copy link
Collaborator Author

TODO:

  • rewrite the order_iso lemmas for galois connections instead of order_iso
  • change the order_iso hypotheses from complete_lattice to conditionally_complete_lattice? (under enough boundedness assumptions on the filter)

@sgouezel
Copy link
Collaborator

a new file order/filter/ennreal.lean would be a good place, I think.

@RemyDegenne RemyDegenne changed the title feat(measure_theory/ess_sup): define essential supremum and infimum feat(order/limsup_liminf, order/filter/ennreal): add properties of limsup for ennreal-valued functions Jan 15, 2021
@RemyDegenne RemyDegenne added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 15, 2021
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I would have dropped completely the esssup file: even if it just boils down to restating limsup lemmas, it will certainly be useful for people that don't think of the essential supremum as the limsup along the ae filter (i.e., everyone :-)

src/order/filter/ennreal.lean Outdated Show resolved Hide resolved
src/measure_theory/ess_sup.lean Outdated Show resolved Hide resolved
src/order/filter/ennreal.lean Outdated Show resolved Hide resolved
src/order/filter/ennreal.lean Outdated Show resolved Hide resolved
src/order/filter/ennreal.lean Outdated Show resolved Hide resolved
@RemyDegenne RemyDegenne added awaiting-author A reviewer has asked the author a question or requested changes awaiting-review The author would like community review of the PR and removed awaiting-review The author would like community review of the PR awaiting-author A reviewer has asked the author a question or requested changes labels Jan 18, 2021
@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 18, 2021
bors bot pushed a commit that referenced this pull request Jan 18, 2021
…msup for ennreal-valued functions (#5746)




Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@bors
Copy link

bors bot commented Jan 18, 2021

Build failed:

@robertylewis robertylewis removed the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jan 18, 2021
@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jan 18, 2021
bors bot pushed a commit that referenced this pull request Jan 18, 2021
…msup for ennreal-valued functions (#5746)




Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@bors
Copy link

bors bot commented Jan 18, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/limsup_liminf, order/filter/ennreal): add properties of limsup for ennreal-valued functions [Merged by Bors] - feat(order/limsup_liminf, order/filter/ennreal): add properties of limsup for ennreal-valued functions Jan 18, 2021
@bors bors bot closed this Jan 18, 2021
@bors bors bot deleted the ess_sup branch January 18, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants