Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/*): introduces complemented lattices #5747

Closed
wants to merge 77 commits into from
Closed

[Merged by Bors] - feat(order/*): introduces complemented lattices #5747

wants to merge 77 commits into from

Conversation

awainverse
Copy link
Collaborator

@awainverse awainverse commented Jan 14, 2021 •
edited by github-actions bot

Defines is_complemented on bounded lattices
Proves facts about complemented modular lattices
Provides two instances of is_complemented on submodule lattices

awainverse and others added 30 commits December 21, 2020 10:43
@awainverse
init
f79d5c7
@awainverse
is_maximal
566d1b0
@jcommelin
golf bot_ne_top
20983a7
@awainverse
new file
f3ce35d
@awainverse
oleans
3df7d0c
@awainverse
more_oleans
91d515f
@awainverse
less_imports
7cefefb
@awainverse
oleans
3331de1
@awainverse
oleans
a34493a
@awainverse
woo
a89f2da
@awainverse
lattice_intervals
cc84c45
@awainverse
init
c38f38f
@awainverse
mergable
314783a
@awainverse
oleans
86282ed
@awainverse
review
e43cc91
@awainverse
review
585ae59
@awainverse
Merge remote-tracking branch 'origin/master' into atoms2
d890d30
@awainverse
init
f1be664
@awainverse
Merge remote-tracking branch 'origin/troubleshoot_analytic' into atoms2
956bb26
@awainverse
ext
d694a6f
@awainverse
Merge remote-tracking branch 'origin/lattice_intervals' into atoms2
6b2c282
@awainverse
Merge remote-tracking branch 'origin/troubleshoot_analytic' into atoms2
0924919
@awainverse
less_tidy
1bee34a
@awainverse
Merge remote-tracking branch 'origin/troubleshoot_analytic' into atoms2
01a7a5f
@awainverse
Merge remote-tracking branch 'origin/master' into atoms2
6cd901d
@awainverse
merge_master
9098f1f
@awainverse
Merge remote-tracking branch 'origin/master' into atoms2
9f73619
@awainverse @bryangingechen
Apply suggestions from code review
d1a586a 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@awainverse
init
ebd62be
@awainverse
lint
bc476b0
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 16, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 16, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 22, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jan 22, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@awainverse awainverse added the awaiting-review The author would like community review of the PR label Jan 25, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 25, 2021
jcommelin
jcommelin approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Vierkantor
Vierkantor approved these changes Feb 5, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait, let's get this merged.

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 5, 2021
bors bot pushed a commit that referenced this pull request Feb 5, 2021
@awainverse @jcommelin
feat(order/*): introduces complemented lattices (#5747)
70269f3 
Defines `is_complemented` on bounded lattices
Proves facts about complemented modular lattices
Provides two instances of `is_complemented` on submodule lattices



Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 5, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/*): introduces complemented lattices [Merged by Bors] - feat(order/*): introduces complemented lattices Feb 5, 2021
@bors bors bot closed this Feb 5, 2021
@bors bors bot deleted the lattice_facts branch February 5, 2021 15:46
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@awainverse @jcommelin @b-mehta
feat(order/*): introduces complemented lattices (#5747)
2ae2eff 
Defines `is_complemented` on bounded lattices
Proves facts about complemented modular lattices
Provides two instances of `is_complemented` on submodule lattices



Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@awainverse @Vierkantor @jcommelin