Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/mv_polynomial): stronger degrees_X for nontrivial R #5758

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(data/mv_polynomial): stronger degrees_X for nontrivial R #5758

wants to merge 3 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 15, 2021 •
edited by bryangingechen

Also rename degrees_X to degrees_X' and mark degrees_{zero,one} with simp.

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jan 15, 2021
@bryangingechen bryangingechen changed the title chore(data/mv_polynomial): mark degrees_{zero,one} with simp feat(data/mv_polynomial): stronger degrees_X for nontrivial R Jan 15, 2021
@bryangingechen
Copy link
Collaborator

It's nitpicky but I think the degrees_X change is bigger than adding simp.

@eric-wieser
Copy link
Member Author

That's fair, this PR expanded a bit after I created it.

bryangingechen
bryangingechen approved these changes Jan 15, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 15, 2021
bors bot pushed a commit that referenced this pull request Jan 15, 2021
@eric-wieser
feat(data/mv_polynomial): stronger degrees_X for nontrivial R (#5758
8b4b941 
)

Also rename `degrees_X` to `degrees_X'` and mark `degrees_{zero,one}` with `simp`.
@bors
Copy link

bors bot commented Jan 15, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/mv_polynomial): stronger degrees_X for nontrivial R [Merged by Bors] - feat(data/mv_polynomial): stronger degrees_X for nontrivial R Jan 15, 2021
@bors bors bot closed this Jan 15, 2021
@bors bors bot deleted the eric-wieser/mv_polynomial.degrees branch January 15, 2021 17:48
b-mehta pushed a commit that referenced this pull request Jan 16, 2021
@eric-wieser @b-mehta
feat(data/mv_polynomial): stronger degrees_X for nontrivial R (#5758
d6aa7ec 
)

Also rename `degrees_X` to `degrees_X'` and mark `degrees_{zero,one}` with `simp`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @bryangingechen