Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/closure): closure operator from galois connection #5764

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(order/closure): closure operator from galois connection #5764

wants to merge 3 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Jan 16, 2021

Construct a closure operator from a galois connection

@b-mehta b-mehta added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Jan 16, 2021
@jcommelin jcommelin self-assigned this Jan 16, 2021
bryangingechen
bryangingechen reviewed Jan 16, 2021
View reviewed changes
src/order/closure.lean Outdated Show resolved Hide resolved
src/order/closure.lean Outdated Show resolved Hide resolved
src/order/closure.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 16, 2021
jcommelin
jcommelin approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from Bryan's comment: LGTM

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR awaiting-author A reviewer has asked the author a question or requested changes labels Jan 16, 2021
bors bot pushed a commit that referenced this pull request Jan 16, 2021
@b-mehta
feat(order/closure): closure operator from galois connection (#5764)
1485e94 
Construct a closure operator from a galois connection
@bors
Copy link

bors bot commented Jan 16, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jan 16, 2021
@b-mehta
feat(order/closure): closure operator from galois connection (#5764)
9acd349 
Construct a closure operator from a galois connection
@bors
Copy link

bors bot commented Jan 16, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/closure): closure operator from galois connection [Merged by Bors] - feat(order/closure): closure operator from galois connection Jan 16, 2021
@bors bors bot closed this Jan 16, 2021
@bors bors bot deleted the connection-closure branch January 16, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees

@jcommelin jcommelin

Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@b-mehta @jcommelin @bryangingechen