-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(field_theory/normal): Splitting field is normal #5768
Conversation
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
Nice! The proof is longish, and seems to spend quite some time on setting up the right type class instances (unfortunately). I'm not sure if we can do much about that. But I'm wondering... do you think there are parts that could be made reusable by putting them in separate lemmas? |
It's hard to extract lemmas since a lot of the proof depends on the specific setup. One possibility that I see is this lemma which would shorten the proof of
(I guess you can weaken the hypotheses to the same as for |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…over-community/mathlib into splitting_field_is_normal merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Proves that splitting fields are normal. Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
Build failed (retrying...): |
Proves that splitting fields are normal. Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
Build failed (retrying...): |
Proves that splitting fields are normal. Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
Build failed: |
Sorry, this file needs to be updated to the new bors r- bors d+ |
✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
Proves that splitting fields are normal. Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
Proves that splitting fields are normal.