Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(field_theory/minpoly): meaningful variable names #5773

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - chore(field_theory/minpoly): meaningful variable names #5773

wants to merge 9 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Jan 16, 2021 •
edited by github-actions bot

@jcommelin
chore(field_theory|ring_theory|linear_algebra): rename minimal_polyno…
b9ec9a8 
…mial to minpoly

This PR renames:

`minimal_polynomial` -> `minpoly`

This PR moves a file:

  src/field_theory/minimal_polynomial.lean -> src/field_theory/minpoly.lean
@jcommelin
Fix duplicate namespace
557c546
@jcommelin
chore(field_theory/minpoly): meaningful variable names
fb37f9c
@jcommelin jcommelin added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jan 16, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 16, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 16, 2021
@jcommelin jcommelin mentioned this pull request Jan 16, 2021
Closed
2 tasks
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jan 16, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 18, 2021
bryangingechen
bryangingechen approved these changes Jan 18, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some docstring formatting nitpicks along the way.

Thanks!
bors d+

src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
src/field_theory/minpoly.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 18, 2021

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 18, 2021
@jcommelin @bryangingechen
Apply suggestions from code review
54c02d0 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@jcommelin
Copy link
Member Author

@bryangingechen thanks for fixing all those docstrings!

@jcommelin
Copy link
Member Author

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 18, 2021
bors bot pushed a commit that referenced this pull request Jan 18, 2021
@jcommelin
chore(field_theory/minpoly): meaningful variable names (#5773)
8ab1a39
@bors
Copy link

bors bot commented Jan 18, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(field_theory/minpoly): meaningful variable names [Merged by Bors] - chore(field_theory/minpoly): meaningful variable names Jan 18, 2021
@bors bors bot closed this Jan 18, 2021
@bors bors bot deleted the minpoly-varnames branch January 18, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcommelin @bryangingechen