[Merged by Bors] - chore(group_theory/perm/{sign,cycles}): renaming for dot notation, linting, formatting #5777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryangingechen
added
the
awaiting-review
|
Nice! Thanks a lot! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 16, 2021
…nting, formatting (#5777) Declarations renamed in `group_theory/perm/sign.lean` (all of these are under `equiv.perm`): - `disjoint_mul_comm` -> `disjoint.mul_comm` - `disjoint_mul_left` -> `disjoint.mul_left` - `disjoint_mul_right` -> `disjoint.mul_right` - `is_swap_of_subtype` -> `is_swap.of_subtype_is_swap` - `sign_eq_of_is_swap` -> `is_swap.sign_eq` Declarations renamed in `group_theory/perm/cycles.lean` (all of these are under `equiv.perm`): - `is_cycle_swap` -> `is_cycle.swap` - `is_cycle_inv` -> `is_cycle.inv` - `exists_gpow_eq_of_is_cycle` -> `is_cycle.exists_gpow_eq` - `exists_pow_eq_of_is_cycle` -> `is_cycle.exists_pow_eq` - `eq_swap_of_is_cycle_of_apply_apply_eq_self` -> `eq_swap_of_apply_apply_eq_self` - `is_cycle_swap_mul` -> `is_cycle.swap_mul` - `sign_cycle` -> `is_cycle.sign` - `apply_eq_self_iff_of_same_cycle` -> `same_cycle.apply_eq_self_iff` - `same_cycle_of_is_cycle` -> `is_cycle.same_cycle` - `cycle_of_apply_of_same_cycle` -> `same_cycle.cycle_of_apply` - `cycle_of_cycle` -> `is_cycle.cycle_of_eq` I also added a basic module doc string to `group_theory/perm/cycles.lean`.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jan 17, 2021
…nting, formatting (#5777) Declarations renamed in `group_theory/perm/sign.lean` (all of these are under `equiv.perm`): - `disjoint_mul_comm` -> `disjoint.mul_comm` - `disjoint_mul_left` -> `disjoint.mul_left` - `disjoint_mul_right` -> `disjoint.mul_right` - `is_swap_of_subtype` -> `is_swap.of_subtype_is_swap` - `sign_eq_of_is_swap` -> `is_swap.sign_eq` Declarations renamed in `group_theory/perm/cycles.lean` (all of these are under `equiv.perm`): - `is_cycle_swap` -> `is_cycle.swap` - `is_cycle_inv` -> `is_cycle.inv` - `exists_gpow_eq_of_is_cycle` -> `is_cycle.exists_gpow_eq` - `exists_pow_eq_of_is_cycle` -> `is_cycle.exists_pow_eq` - `eq_swap_of_is_cycle_of_apply_apply_eq_self` -> `eq_swap_of_apply_apply_eq_self` - `is_cycle_swap_mul` -> `is_cycle.swap_mul` - `sign_cycle` -> `is_cycle.sign` - `apply_eq_self_iff_of_same_cycle` -> `same_cycle.apply_eq_self_iff` - `same_cycle_of_is_cycle` -> `is_cycle.same_cycle` - `cycle_of_apply_of_same_cycle` -> `same_cycle.cycle_of_apply` - `cycle_of_cycle` -> `is_cycle.cycle_of_eq` I also added a basic module doc string to `group_theory/perm/cycles.lean`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declarations renamed in
group_theory/perm/sign.lean(all of these are underequiv.perm):disjoint_mul_comm->disjoint.mul_commdisjoint_mul_left->disjoint.mul_leftdisjoint_mul_right->disjoint.mul_rightis_swap_of_subtype->is_swap.of_subtype_is_swapsign_eq_of_is_swap->is_swap.sign_eqDeclarations renamed in
group_theory/perm/cycles.lean(all of these are underequiv.perm):is_cycle_swap->is_cycle.swapis_cycle_inv->is_cycle.invexists_gpow_eq_of_is_cycle->is_cycle.exists_gpow_eqexists_pow_eq_of_is_cycle->is_cycle.exists_pow_eqeq_swap_of_is_cycle_of_apply_apply_eq_self->eq_swap_of_apply_apply_eq_selfis_cycle_swap_mul->is_cycle.swap_mulsign_cycle->is_cycle.signapply_eq_self_iff_of_same_cycle->same_cycle.apply_eq_self_iffsame_cycle_of_is_cycle->is_cycle.same_cyclecycle_of_apply_of_same_cycle->same_cycle.cycle_of_applycycle_of_cycle->is_cycle.cycle_of_eqI also added a basic module doc string to
group_theory/perm/cycles.lean.As promised in #5665 (review).