Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/lie/basic): define the radical of a Lie algebra and prove it is solvable #5833

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(algebra/lie/basic): define the radical of a Lie algebra and prove it is solvable #5833

wants to merge 4 commits into from

Conversation

ocfnash
Copy link
Collaborator

@ocfnash ocfnash commented Jan 21, 2021

No description provided.

@ocfnash ocfnash added the awaiting-review The author would like community review of the PR label Jan 21, 2021
jcommelin
jcommelin reviewed Jan 21, 2021
View reviewed changes
src/algebra/lie/basic.lean Outdated Show resolved Hide resolved
src/algebra/lie/basic.lean Outdated Show resolved Hide resolved
src/algebra/lie/basic.lean Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 22, 2021
@ocfnash
Replace lie_submodule.top_of_bot_eq_bot with stronger `lie_submodul…
14df210 
…e.of_bot_eq_bot`

Likewise for `lie_ideal`s.
@ocfnash ocfnash added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 22, 2021
jcommelin
jcommelin reviewed Jan 22, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

src/algebra/lie/basic.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 22, 2021

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ocfnash
Copy link
Collaborator Author

ocfnash commented Jan 22, 2021

bors merge

bors bot pushed a commit that referenced this pull request Jan 22, 2021
@ocfnash
feat(algebra/lie/basic): define the radical of a Lie algebra and prov…
f48ce7e 
…e it is solvable (#5833)
@bors
Copy link

bors bot commented Jan 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/lie/basic): define the radical of a Lie algebra and prove it is solvable [Merged by Bors] - feat(algebra/lie/basic): define the radical of a Lie algebra and prove it is solvable Jan 22, 2021
@bors bors bot closed this Jan 22, 2021
@bors bors bot deleted the lie_algebra_radical branch January 22, 2021 17:20
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ocfnash @jcommelin @YaelDillies