[Merged by Bors] - chore(*/pi): rename *_hom.apply to pi.eval_*_hom #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
awaiting-review
eric-wieser
added
awaiting-author
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
eric-wieser
changed the title
eric-wieser
force-pushed
the
eric-wieser/rename-monoid_hom.apply
branch
from
d5685d7
to
57630bb
Compare
|
My only worry is that these names now become quite long. I've regularly used |
|
Let's see whether CI indicates that code like that has ended up in mathlib. It would certainly help if we had a shorter suffix than |
eric-wieser
added
awaiting-review
|
LGTM the names didn't seem to get much longer, since (at least currently) the namespaces were not opened. bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 15, 2021
These definitions state the fact that fixing an `i` and applying a function `(Π i, f i)` maintains the algebraic structure of the function. We already have a name for this operation, `function.eval`. These isn't a statement about `monoid_hom` or `ring_hom` at all - that just happens to be their type. For this reason, this commit moves all the definitions of this type into the `pi` namespace: * `add_monoid_hom.apply` → `pi.eval_add_monoid_hom` * `monoid_hom.apply` → `pi.eval_monoid_hom` * `ring_hom.apply` → `pi.eval_ring_hom` * `pi.alg_hom.apply` [sic] → `pi.eval_alg_hom` This scales better, because we might want to say that applying a `linear_map` over a non-commutative ring is an `add_monoid_hom`. Using the naming convention established by this commit, that's easy; it's `linear_map.eval_add_monoid_hom` to mirror `pi.apply_add_monoid_hom`. This partially addresses [this zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Naming.3A.20eval.20vs.20apply/near/223813950)
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These definitions state the fact that fixing an
iand applying a function(Π i, f i)maintains the algebraic structure of the function. We already have a name for this operation,function.eval.These isn't a statement about
monoid_homorring_homat all - that just happens to be their type.For this reason, this commit moves all the definitions of this type into the
pinamespace:add_monoid_hom.apply→pi.eval_add_monoid_hommonoid_hom.apply→pi.eval_monoid_homring_hom.apply→pi.eval_ring_hompi.alg_hom.apply[sic] →pi.eval_alg_homThis scales better, because we might want to say that applying a
linear_mapover a non-commutative ring is anadd_monoid_hom. Using the naming convention established by this commit, that's easy; it'slinear_map.eval_add_monoid_homto mirrorpi.apply_add_monoid_hom.This partially addresses this zulip discussion
Split from #5834