Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/set/finite): add to_finset lemma #5883

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(data/set/finite): add to_finset lemma #5883

wants to merge 1 commit into from

Conversation

agusakov
Copy link
Collaborator

Add lemma stating that taking to_finset of the union of two sets is the same as taking the union of to_finset of the sets.

@agusakov agusakov added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Jan 25, 2021
@eric-wieser eric-wieser mentioned this pull request Jan 25, 2021
Closed
bryangingechen
bryangingechen approved these changes Jan 25, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 25, 2021
bors bot pushed a commit that referenced this pull request Jan 25, 2021
@agusakov
feat(data/set/finite): add to_finset lemma (#5883)
3a16e9f 
Add lemma stating that taking to_finset of the union of two sets is the same as taking the union of to_finset of the sets.
@agusakov agusakov requested a review from b-mehta January 25, 2021 18:15
@bors
Copy link

bors bot commented Jan 25, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/set/finite): add to_finset lemma [Merged by Bors] - feat(data/set/finite): add to_finset lemma Jan 25, 2021
@bors bors bot closed this Jan 25, 2021
@bors bors bot deleted the to_finset_union branch January 25, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@bryangingechen bryangingechen bryangingechen approved these changes

@robertylewis robertylewis Awaiting requested review from robertylewis

@b-mehta b-mehta Awaiting requested review from b-mehta

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@agusakov @eric-wieser @bryangingechen