[Merged by Bors] - feat(algebra/euclidean_domain): Unify occurences of div_add_mod and mod_add_div #5884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to unify with nat
…th euclidean domain
…ith euclidean domain
eric-wieser
reviewed
Jan 25, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
reviewed
Jan 25, 2021
eric-wieser
reviewed
Jan 25, 2021
… for int, but not for pnat because of some coercion
|
Are |
They are not, see the issue. Do you have a suggestion for a better name than just 'priming' everything? |
Add in the word
|
eric-wieser
reviewed
Jan 25, 2021
|
I suggest to leave the PR like that and do the potential other two versions, potential renaming, and golfing of proofs for other PRs as it is always very slow to edit such basic files as nat and int. |
Julian-Kuelshammer
added
awaiting-review
eric-wieser
approved these changes
Jan 26, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2021
…od_add_div (#5884) Adding the corresponding commutative version at several places (euclidean domain, nat, pnat, int) whenever there is the other version. In subsequent PRs other proofs in the library which now use some version of `add_comm, exact div_add_mod` or `add_comm, exact mod_add_div` should be golfed. Trying to address issue #1534 Co-authored-by: Julian-Kuelshammer <68201724+Julian-Kuelshammer@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
…od_add_div (#5884) Adding the corresponding commutative version at several places (euclidean domain, nat, pnat, int) whenever there is the other version. In subsequent PRs other proofs in the library which now use some version of `add_comm, exact div_add_mod` or `add_comm, exact mod_add_div` should be golfed. Trying to address issue #1534 Co-authored-by: Julian-Kuelshammer <68201724+Julian-Kuelshammer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the corresponding commutative version at several places (euclidean domain, nat, pnat, int) whenever there is the other version.
In subsequent PRs other proofs in the library which now use some version of
add_comm, exact div_add_modoradd_comm, exact mod_add_divshould be golfed.Trying to address issue #1534