Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(linear_algebra/basic, analysis/normed_space/operator_norm): bundle another argument into the homs #5899

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member


@eric-wieser eric-wieser added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Jan 26, 2021
/-- The continuous linear map obtained by applying a continuous linear map at a given vector.

This is the continuous version of `linear_map.applyₗ`. -/
def apply : E →ₗ[𝕜] (E →L[𝕜] F) →L[𝕜] F :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the fact that the application of a continuous linear map is a continuous bilinear operation, in is_bounded_bilinear_map_apply (in bounded_linear_maps.lean), together with other statements of the same flavor (for instance, the composition of two continuous linear maps is a bilinear operation). I don't know what do to with this -- at least registering the fact that a bounded bilinear map from E x F to G gives rise to a map E ->L[k] -> F ->L[k] G, from which your definition is then a particular case.

All these maps have been registered as (unbundled) bounded bilinear maps because this is the way it has been the most useful for applications, as far as I can tell.

There is the same question for the other definitions: should we register them as bilinear maps, or in which context. The question is really the applications: if you have an application in which your form is more convenient, then we should go this way. If this is just generalization for the sake of generalizing, maybe we should instead wait and see what is needed next.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generalizing for the sake of consistency, not generalization itself - we already have the fully-bundled version for add_monoid_hom, this just adds them for two other homs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. Then I'd still like the continuous version to be a continuous linear map, not just a linear map, and then we can merge this. Also, was there a consensus on the renaming part?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming was something I was planning to leave for a follow-up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'd still like the continuous version to be a continuous linear map,

I don't have the knowledge of how to prove this. To summarize:

  1. Before the PR: apply : E → (E →L[𝕜] F) →L[𝕜] F
  2. With the PR: apply : E →ₗ[𝕜] (E →L[𝕜] F) →L[𝕜] F
  3. Your proposal: apply : E →L[𝕜] (E →L[𝕜] F) →L[𝕜] F`

While obviously 3 would be ideal, I have no idea if it's even true, and proving it is outside of my area of expertise.
Is there any harm in merging this as is? It still makes things like apply (a + b) = apply a + apply b provable by simp, which previously was not true. If you really strongly object, I can remove the map_add' := λ _ _, ext $ λ f, f.map_add _ _, lines, but I don't see why proving less is better than proving more.

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jan 30, 2021
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 4, 2021
@sgouezel
Copy link
Collaborator

sgouezel commented Feb 5, 2021

I have pushed a version with the continuous version. If you're happy with it, you can merge yourself.
bors d+
Thanks!

@bors
Copy link

bors bot commented Feb 5, 2021

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 5, 2021
@eric-wieser
Copy link
Member Author

bors r+

Thanks!

bors bot pushed a commit that referenced this pull request Feb 9, 2021
…dle another argument into the homs (#5899)

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@bors
Copy link

bors bot commented Feb 9, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(linear_algebra/basic, analysis/normed_space/operator_norm): bundle another argument into the homs [Merged by Bors] - chore(linear_algebra/basic, analysis/normed_space/operator_norm): bundle another argument into the homs Feb 9, 2021
@bors bors bot closed this Feb 9, 2021
@bors bors bot deleted the eric-wieser/bundle-apply branch February 9, 2021 03:30
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
…dle another argument into the homs (#5899)

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants