[Merged by Bors] - feat(order/ideal): add partial_order instance to order.ideal #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some instances for `order.ideal`, some of them conditional on having extra structure on the carrier preorder `P`: * In all cases, `ideal P` is a partial order. * If `P` has a bottom element, so does `ideal P`. * If `P` has a top element, so does `ideal P`. (Although this could be weekened to `P` being directed.) Also, add some `@[ext]`, `@[simp]`, `@[trans]` lemmas.
bryangingechen
added
the
awaiting-review
eric-wieser
reviewed
Jan 26, 2021
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2021
Add some instances for `order.ideal`, some of them conditional on having extra structure on the carrier preorder `P`: * In all cases, `ideal P` is a partial order. * If `P` has a bottom element, so does `ideal P`. * If `P` has a top element, so does `ideal P`. (Although this could be weekened to `P` being directed.) Also, add some `@[ext]`, `@[simp]`, `@[trans]` lemmas.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
Add some instances for `order.ideal`, some of them conditional on having extra structure on the carrier preorder `P`: * In all cases, `ideal P` is a partial order. * If `P` has a bottom element, so does `ideal P`. * If `P` has a top element, so does `ideal P`. (Although this could be weekened to `P` being directed.) Also, add some `@[ext]`, `@[simp]`, `@[trans]` lemmas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some instances for
order.ideal, some of them conditional onhaving extra structure on the carrier preorder
P:In all cases,
ideal Pis a partial order.If
Phas a bottom element, so doesideal P.If
Phas a top element, so doesideal P.(Although this could be weekened to
Pbeing directed.)Also, add some
@[ext],@[simp],@[trans]lemmas.