Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(*): split some long lines #5959

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(*): split some long lines #5959

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 29, 2021

@urkud urkud added awaiting-review The author would like community review of the PR lintfix This PR only fixes linting errors labels Jan 29, 2021
bryangingechen
bryangingechen approved these changes Jan 29, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors d+

src/data/holor.lean Outdated Show resolved Hide resolved
src/topology/metric_space/emetric_space.lean Outdated Show resolved Hide resolved
src/topology/metric_space/gromov_hausdorff_realized.lean Outdated Show resolved Hide resolved
src/topology/metric_space/gromov_hausdorff_realized.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 29, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 29, 2021
@urkud @bryangingechen
Apply suggestions from code review
32f836a 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@urkud
Copy link
Member Author

urkud commented Jan 30, 2021

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 30, 2021
bors bot pushed a commit that referenced this pull request Jan 30, 2021
@urkud
chore(*): split some long lines (#5959)
d6fe605
@bors
Copy link

bors bot commented Jan 30, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(*): split some long lines [Merged by Bors] - chore(*): split some long lines Jan 30, 2021
@bors bors bot closed this Jan 30, 2021
@bors bors bot deleted the long-lines4 branch January 30, 2021 18:21
b-mehta pushed a commit that referenced this pull request Jan 30, 2021
@urkud @b-mehta
chore(*): split some long lines (#5959)
e9e6f32
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@urkud @b-mehta
chore(*): split some long lines (#5959)
b888d0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. lintfix This PR only fixes linting errors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @bryangingechen