Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(*) add mod_add_div' and div_add_mod' and golf proofs #5962

Closed
wants to merge 4 commits into from

Conversation

Julian-Kuelshammer
Copy link
Collaborator

@Julian-Kuelshammer Julian-Kuelshammer commented Jan 29, 2021

Resolves issue #1534.

Name of nat.mod_add_div shouldn't be changed as this is in core. Better name suggestions for mod_add_div' and div_add_mod' welcome.


@Julian-Kuelshammer Julian-Kuelshammer added the WIP Work in progress label Jan 29, 2021
@Julian-Kuelshammer Julian-Kuelshammer added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jan 30, 2021
@bors
Copy link

bors bot commented Jan 31, 2021

✌️ Julian-Kuelshammer can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Thanks!
bors d+

src/algebra/euclidean_domain.lean Outdated Show resolved Hide resolved
@bryangingechen bryangingechen added delegated The PR author may merge after reviewing final suggestions. awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 31, 2021
@Julian-Kuelshammer
Copy link
Collaborator Author

bors r+

@Julian-Kuelshammer Julian-Kuelshammer added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. labels Feb 1, 2021
bors bot pushed a commit that referenced this pull request Feb 1, 2021
Resolves issue #1534.

Name of nat.mod_add_div shouldn't be changed as this is in core. Better name suggestions for mod_add_div' and div_add_mod' welcome.



Co-authored-by: Julian <kuelsha@mathematik.uni-stuttgart.de>
@bors
Copy link

bors bot commented Feb 1, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(*) add mod_add_div' and div_add_mod' and golf proofs [Merged by Bors] - chore(*) add mod_add_div' and div_add_mod' and golf proofs Feb 1, 2021
@bors bors bot closed this Feb 1, 2021
@bors bors bot deleted the mod_add_div2 branch February 1, 2021 19:15
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
Resolves issue #1534.

Name of nat.mod_add_div shouldn't be changed as this is in core. Better name suggestions for mod_add_div' and div_add_mod' welcome.



Co-authored-by: Julian <kuelsha@mathematik.uni-stuttgart.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants