-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(*) add mod_add_div' and div_add_mod' and golf proofs #5962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julian-Kuelshammer
added
awaiting-review
The author would like community review of the PR
and removed
WIP
Work in progress
labels
Jan 30, 2021
✌️ Julian-Kuelshammer can now approve this pull request. To approve and merge a pull request, simply reply with |
bryangingechen
approved these changes
Jan 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM. Thanks!
bors d+
bryangingechen
added
delegated
The PR author may merge after reviewing final suggestions.
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Jan 31, 2021
bors r+ |
Julian-Kuelshammer
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
delegated
The PR author may merge after reviewing final suggestions.
labels
Feb 1, 2021
bors bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
Resolves issue #1534. Name of nat.mod_add_div shouldn't be changed as this is in core. Better name suggestions for mod_add_div' and div_add_mod' welcome. Co-authored-by: Julian <kuelsha@mathematik.uni-stuttgart.de>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
chore(*) add mod_add_div' and div_add_mod' and golf proofs
[Merged by Bors] - chore(*) add mod_add_div' and div_add_mod' and golf proofs
Feb 1, 2021
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
Resolves issue #1534. Name of nat.mod_add_div shouldn't be changed as this is in core. Better name suggestions for mod_add_div' and div_add_mod' welcome. Co-authored-by: Julian <kuelsha@mathematik.uni-stuttgart.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #1534.
Name of nat.mod_add_div shouldn't be changed as this is in core. Better name suggestions for mod_add_div' and div_add_mod' welcome.