[Merged by Bors] - refactor(analysis/asymptotics): make definitions immediately irreducible #6021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertylewis
added
the
mathport
fpvandoorn
reviewed
Feb 3, 2021
src/analysis/asymptotics.lean
Outdated
| @@ -383,12 +403,12 @@ by simp only [is_O_with, norm_norm] | |||
| alias is_O_with_norm_right ↔ asymptotics.is_O_with.of_norm_right asymptotics.is_O_with.norm_right | |||
|
|
|||
| @[simp] theorem is_O_norm_right : is_O f (λ x, ∥g' x∥) l ↔ is_O f g' l := | |||
| exists_congr $ λ _, is_O_with_norm_right | |||
| by unfold is_O; exact exists_congr (λ _, is_O_with_norm_right) | |||
There was a problem hiding this comment.
Suggested change
| by unfold is_O; exact exists_congr (λ _, is_O_with_norm_right) | |
| by { unfold is_O, exact exists_congr (λ _, is_O_with_norm_right) } |
Here and below, can you use the by { t1, t2 } idiom instead of by t1; t2?
|
✌️ gebner can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of 🍀, where
attribute [irreducible]will no longer work.