Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/list/basic): drop_eq_nil_of_le #6029

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(data/list/basic): drop_eq_nil_of_le #6029

wants to merge 2 commits into from

Conversation

pechersky
Copy link
Collaborator

@pechersky pechersky added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Feb 3, 2021
bryangingechen
bryangingechen approved these changes Feb 3, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 3, 2021
bors bot pushed a commit that referenced this pull request Feb 3, 2021
@pechersky
feat(data/list/basic): drop_eq_nil_of_le (#6029)
e856f83
@bors
Copy link

bors bot commented Feb 3, 2021

Canceled.

@pechersky
Copy link
Collaborator Author

bors r-

@bryangingechen bryangingechen added delegated The PR author may merge after reviewing final suggestions. and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Feb 3, 2021
@bryangingechen
Copy link
Collaborator

bors d+

@bors
Copy link

bors bot commented Feb 3, 2021

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@pechersky
Copy link
Collaborator Author

bors r-

@pechersky
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 4, 2021
@pechersky
feat(data/list/basic): drop_eq_nil_of_le (#6029)
7812afa
@bors
Copy link

bors bot commented Feb 4, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/list/basic): drop_eq_nil_of_le [Merged by Bors] - feat(data/list/basic): drop_eq_nil_of_le Feb 4, 2021
@bors bors bot closed this Feb 4, 2021
@bors bors bot deleted the pechersky/drop-eq-nil-le branch February 4, 2021 06:49
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@pechersky @b-mehta
feat(data/list/basic): drop_eq_nil_of_le (#6029)
e28a770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pechersky @bryangingechen