[Merged by Bors] - chore(algebra/module/prod): add missing instances #6055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
awaiting-review
Closed
1 task
This adds the following instances for `prod`: * `is_scalar_tower` * `smul_comm_class` * `mul_action` * `distrib_mul_action` It also renames the type variables to match the usual convention for modules
eric-wieser
force-pushed
the
eric-wieser/prod.smul_comm_class
branch
from
d4a54b8
to
d595e92
Compare
eric-wieser
changed the title
urkud
reviewed
Feb 8, 2021
src/algebra/module/prod.lean
Outdated
| [semimodule R M] [semimodule R N] [semimodule S M] [semimodule S N] | ||
| [smul_comm_class R S M] [smul_comm_class R S N] : | ||
| smul_comm_class R S (M × N) := | ||
| { smul_comm := λ r s x, mk.inj_iff.mpr ⟨smul_comm _ _ _, smul_comm _ _ _⟩ } |
There was a problem hiding this comment.
This instance doesn't need semimodules, only has_scalars. Otherwise LGTM
bors d+
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 8, 2021
This adds the following instances for `prod`: * `is_scalar_tower` * `smul_comm_class` * `mul_action` * `distrib_mul_action` It also renames the type variables to match the usual convention for modules
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
This adds the following instances for `prod`: * `is_scalar_tower` * `smul_comm_class` * `mul_action` * `distrib_mul_action` It also renames the type variables to match the usual convention for modules
YaelDillies
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following instances for
prod:is_scalar_towersmul_comm_classmul_actiondistrib_mul_actionIt also renames the type variables to match the usual convention for modules