Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/ordered_monoid): min_*_distrib #6144

Closed
wants to merge 6 commits into from

Conversation

pechersky
Copy link
Collaborator

@pechersky pechersky commented Feb 10, 2021

Also provide a canonically_linear_ordered_add_monoid instances for nat, nnreal, cardinal and with_top.


I don't need the max versions, but someone could write those.

@pechersky pechersky added the awaiting-review The author would like community review of the PR label Feb 10, 2021
@bryangingechen
Copy link
Collaborator

bryangingechen commented Feb 10, 2021

Do you mind adding canonically_linear_ordered_add_monoid instances for nnreal, ennreal and cardinal as well?

edit: added some more examples

@pechersky
Copy link
Collaborator Author

Do you mind adding canonically_linear_ordered_add_monoid instances for nnreal, ennreal and cardinal as well?

edit: added some more examples

Added -- but I don't understand why the cardinal one needs noncomputable when the instances above it, that also rely on cardinal.linear_order, are not noncomputable.

@pechersky
Copy link
Collaborator Author

Somehow, the derive canonically_linear_ordered_add_monoid broke a proof later on. This might have to do with the weird diamond that Yury commented on in the file. But I don't know how to debug that.

@bryangingechen
Copy link
Collaborator

@pechersky @RemyDegenne The plan is to merge https://github.com/leanprover-community/mathlib/tree/ennreal_lattice_issue into this PR if it builds, right?

@RemyDegenne
Copy link
Collaborator

We could also merge this first. The other branch should build but it has some weird behaviour that I don't understand, and it may take a while to fix. canonically_linear_ordered_add_monoid verifies all properties of a semilattice_sup_bot but I cannot find a way to make lemmas on semilattice_sup_bot usable for it. Either I end up with two sup or with two bot.

@eric-wieser
Copy link
Member

My opinion is that we should just merge this one.

@bryangingechen
Copy link
Collaborator

OK, thanks everyone!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 10, 2021
bors bot pushed a commit that referenced this pull request Feb 10, 2021
Also provide a `canonically_linear_ordered_add_monoid` instances for `nat`, `nnreal`, `cardinal` and `with_top`.



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Feb 10, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/ordered_monoid): min_*_distrib [Merged by Bors] - feat(algebra/ordered_monoid): min_*_distrib Feb 10, 2021
@bors bors bot closed this Feb 10, 2021
@bors bors bot deleted the pechersky/nat-canonical-linear-add-monoid branch February 10, 2021 21:00
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
Also provide a `canonically_linear_ordered_add_monoid` instances for `nat`, `nnreal`, `cardinal` and `with_top`.



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants