Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(field_theory/polynomial_galois_group): Restriction from splitting field of composition #6148

Closed
wants to merge 6 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Feb 10, 2021

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Feb 10, 2021
@Vierkantor Vierkantor self-requested a review February 10, 2021 20:32
@tb65536 tb65536 added awaiting-review The author would like community review of the PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Feb 10, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! If you wanted to do some things differently, I have a couple of suggestions, but your results should be fine as they are.

bors d+

src/field_theory/polynomial_galois_group.lean Show resolved Hide resolved
src/field_theory/polynomial_galois_group.lean Outdated Show resolved Hide resolved
src/field_theory/polynomial_galois_group.lean Show resolved Hide resolved
src/field_theory/polynomial_galois_group.lean Outdated Show resolved Hide resolved
src/field_theory/polynomial_galois_group.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 11, 2021

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Vierkantor Vierkantor added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 11, 2021
tb65536 and others added 3 commits February 11, 2021 07:29
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@tb65536
Copy link
Collaborator Author

tb65536 commented Feb 11, 2021

bors r+

@tb65536
Copy link
Collaborator Author

tb65536 commented Feb 11, 2021

bors cancel

@bors
Copy link

bors bot commented Feb 11, 2021

Canceled.

@tb65536
Copy link
Collaborator Author

tb65536 commented Feb 11, 2021

bors r+

bors bot pushed a commit that referenced this pull request Feb 11, 2021
…g field of composition (#6148)

Defines the surjective restriction map from the splitting field of a composition



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 11, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/polynomial_galois_group): Restriction from splitting field of composition [Merged by Bors] - feat(field_theory/polynomial_galois_group): Restriction from splitting field of composition Feb 11, 2021
@bors bors bot closed this Feb 11, 2021
@bors bors bot deleted the restrict_comp branch February 11, 2021 20:21
jcommelin pushed a commit that referenced this pull request Feb 11, 2021
…g field of composition (#6148)

Defines the surjective restriction map from the splitting field of a composition



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
…g field of composition (#6148)

Defines the surjective restriction map from the splitting field of a composition



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants