Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(number_theory/ADE_inequality): the inequality 1/p + 1/q + 1/r > 1 #6156

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(number_theory/ADE_inequality): the inequality 1/p + 1/q + 1/r > 1 #6156

wants to merge 7 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Feb 10, 2021
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 10, 2021
@jcommelin @semorrison
Apply suggestions from code review
bcd7a57 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 11, 2021
@semorrison
Copy link
Collaborator

I only wonder if ADE_classification_inequality might be more informative that pqr.

I forget now how the platonic solids argument goes --- can you factor it through this inequality? I don't think the other "big" ADE classification (graphs with graph norm less than 2) can be related to this inequality, on the other hand.

@semorrison
Copy link
Collaborator

But besides the naming question I'm happy for this to be merged.

bors d+

@bors
Copy link

bors bot commented Feb 11, 2021

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 12, 2021
@jcommelin
Copy link
Member Author

@semorrison you meant renaming the namespace, right? I've changed it to ADE_inequality.
Did you mean other renames as well?

@semorrison
Copy link
Collaborator

Looks great!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 13, 2021
@bryangingechen bryangingechen changed the title feat(number_theory/pqr): the inequality 1/p + 1/q + 1/r > 1 feat(number_theory/ADE_inequality): the inequality 1/p + 1/q + 1/r > 1 Feb 13, 2021
bors bot pushed a commit that referenced this pull request Feb 13, 2021
@jcommelin
feat(number_theory/ADE_inequality): the inequality 1/p + 1/q + 1/r > 1 (
e79bf05 
#6156)
@bors
Copy link

bors bot commented Feb 13, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(number_theory/ADE_inequality): the inequality 1/p + 1/q + 1/r > 1 [Merged by Bors] - feat(number_theory/ADE_inequality): the inequality 1/p + 1/q + 1/r > 1 Feb 13, 2021
@bors bors bot closed this Feb 13, 2021
@bors bors bot deleted the pqr branch February 13, 2021 03:55
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@jcommelin @b-mehta
feat(number_theory/ADE_inequality): the inequality 1/p + 1/q + 1/r > 1 (
b2206f5 
#6156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcommelin @semorrison @bryangingechen