[Merged by Bors] - refactor(algebra/lie/of_associative): remove ring_commutator namespace; use ring instead
#6181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace; use `ring` instead The `old_structure_cmd` change to `lie_algebra.is_simple` is unrelated and is included here only for convenience.
ocfnash
added
the
awaiting-review
jcommelin
reviewed
Feb 11, 2021
jcommelin
added
awaiting-author
ocfnash
added
awaiting-review
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2021
…ace; use `ring` instead (#6181) The `old_structure_cmd` change to `lie_algebra.is_simple` is unrelated and is included here only for convenience. `ring_commutator.commutator` -> `ring.lie_def`
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ring_commutator namespace; use ring insteadring_commutator namespace; use ring instead
jcommelin
pushed a commit
that referenced
this pull request
Feb 11, 2021
…ace; use `ring` instead (#6181) The `old_structure_cmd` change to `lie_algebra.is_simple` is unrelated and is included here only for convenience. `ring_commutator.commutator` -> `ring.lie_def`
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
…ace; use `ring` instead (#6181) The `old_structure_cmd` change to `lie_algebra.is_simple` is unrelated and is included here only for convenience. `ring_commutator.commutator` -> `ring.lie_def`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
old_structure_cmdchange tolie_algebra.is_simpleis unrelated and isincluded here only for convenience.
ring_commutator.commutator->ring.lie_defThese are the final bits of refactoring that I wanted to do for Lie theory.