Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/set/intervals/basic): 24 lemmas about membership of arithmetic operations #6202

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(data/set/intervals/basic): 24 lemmas about membership of arithmetic operations #6202

wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser mentioned this pull request Feb 12, 2021
Closed
@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Feb 12, 2021
@adomani
Copy link
Collaborator

adomani commented Feb 12, 2021

I like these lemmas: as you know, I actually needed one of them!

Thank you for taking the time to put them all in!

@adomani
Copy link
Collaborator

adomani commented Feb 12, 2021

Thank you very much for taking the time to create this PR!

Do you think that it might make sense to also add the "infinite" versions, Iic...? I find the versions that are already in very useful, since they deal at once with two inequalities.

Are the one-sided ones defeq to existing lemmas?

@eric-wieser
Copy link
Member Author

I didn't know the infinite ones existed, so I'll leave writing lemmas for those to someone who has thought about them!

bryangingechen
bryangingechen approved these changes Feb 12, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 12, 2021
bors bot pushed a commit that referenced this pull request Feb 12, 2021
@eric-wieser
feat(data/set/intervals/basic): 24 lemmas about membership of arithme…
dd13f00 
…tic operations (#6202)
@bors
Copy link

bors bot commented Feb 13, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/set/intervals/basic): 24 lemmas about membership of arithmetic operations [Merged by Bors] - feat(data/set/intervals/basic): 24 lemmas about membership of arithmetic operations Feb 13, 2021
@bors bors bot closed this Feb 13, 2021
@bors bors bot deleted the eric-wieser/interval-lemmas branch February 13, 2021 00:49
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@eric-wieser @b-mehta
feat(data/set/intervals/basic): 24 lemmas about membership of arithme…
47275b9 
…tic operations (#6202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

@adomani adomani Awaiting requested review from adomani

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-wieser @adomani @bryangingechen