Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/group/pi): replace a lemma with @[simps] #6203

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(algebra/group/pi): replace a lemma with @[simps] #6203

wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Feb 12, 2021
eric-wieser
eric-wieser commented Feb 12, 2021
View reviewed changes
src/algebra/group/pi.lean
Comment on lines -136 to -137
-- FIXME in the next two `simp only`s,
-- it would be really nice to not have to provide the arguments to `add_apply`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

urkud
urkud reviewed Feb 12, 2021
View reviewed changes
Copy link
Member

@urkud urkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor suggestion.
bors d+

src/algebra/group/pi.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 12, 2021

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser @urkud
Update src/algebra/group/pi.lean
5c1c594 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@eric-wieser
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 13, 2021
@eric-wieser
chore(algebra/group/pi): replace a lemma with @[simps] (#6203)
06fdc08
@urkud urkud added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 13, 2021
@bors
Copy link

bors bot commented Feb 13, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/group/pi): replace a lemma with @[simps] [Merged by Bors] - chore(algebra/group/pi): replace a lemma with @[simps] Feb 13, 2021
@bors bors bot closed this Feb 13, 2021
@bors bors bot deleted the eric-wieser/use-simps branch February 13, 2021 03:55
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@eric-wieser @b-mehta
chore(algebra/group/pi): replace a lemma with @[simps] (#6203)
9abb6a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @urkud