Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/lie/subalgebra): define lattice structure for Lie subalgebras #6279

Closed
wants to merge 3 commits into from

Conversation

ocfnash
Copy link
Collaborator

@ocfnash ocfnash commented Feb 17, 2021

We already have the lattice structure for Lie submodules but not for subalgebras.
This is mostly a lightly-edited copy-paste of the corresponding subset of results
for Lie submodules that remain true for subalgebras.

The results which hold for Lie submodules but not for Lie subalgebras are:

  • sup_coe_to_submodule and mem_sup
  • is_modular_lattice

I have also made a few tweaks to bring the structure and naming of Lie
subalgebras a little closer to that of Lie submodules.


This is in preparation for defining Cartan subalgebas.

…ebras

We already have the lattice structure for Lie submodules but not for subalgebras.
This is mostly a lightly-edited copy-paste of the corresponding subset of results
for Lie submodules that remain true for subalgebras.

The results which hold for Lie submodules but not for Lie subalgebras are:
  - `sup_coe_to_submodule` and `mem_sup`
  - `is_modular_lattice`

I have also made a few tweaks to bring the structure and naming of Lie
subalgebras a little closer to that of Lie submodules.
@ocfnash ocfnash added the awaiting-review The author would like community review of the PR label Feb 17, 2021
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 17, 2021
bors bot pushed a commit that referenced this pull request Feb 17, 2021
…ebras (#6279)

We already have the lattice structure for Lie submodules but not for subalgebras.
This is mostly a lightly-edited copy-paste of the corresponding subset of results
for Lie submodules that remain true for subalgebras.

The results which hold for Lie submodules but not for Lie subalgebras are:
  - `sup_coe_to_submodule` and `mem_sup`
  - `is_modular_lattice`

I have also made a few tweaks to bring the structure and naming of Lie
subalgebras a little closer to that of Lie submodules.



Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Feb 17, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/lie/subalgebra): define lattice structure for Lie subalgebras [Merged by Bors] - feat(algebra/lie/subalgebra): define lattice structure for Lie subalgebras Feb 17, 2021
@bors bors bot closed this Feb 17, 2021
@bors bors bot deleted the lie_subalgebra_lattice branch February 17, 2021 15:28
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
…ebras (#6279)

We already have the lattice structure for Lie submodules but not for subalgebras.
This is mostly a lightly-edited copy-paste of the corresponding subset of results
for Lie submodules that remain true for subalgebras.

The results which hold for Lie submodules but not for Lie subalgebras are:
  - `sup_coe_to_submodule` and `mem_sup`
  - `is_modular_lattice`

I have also made a few tweaks to bring the structure and naming of Lie
subalgebras a little closer to that of Lie submodules.



Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants