Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(measure_theory/interval_integral): add simp attribute to integral_const #6334

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(measure_theory/interval_integral): add simp attribute to integral_const #6334

wants to merge 1 commit into from

Conversation

benjamindavidson
Copy link
Collaborator

By adding a simp attribute to interval_integral.integral_const, the likes of the following become possible:

import measure_theory.interval_integral

example : ∫ x:ℝ in 5..19, (12:ℝ) = 168 := by norm_num

@benjamindavidson benjamindavidson added the awaiting-review The author would like community review of the PR label Feb 21, 2021
bryangingechen
bryangingechen approved these changes Feb 21, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 21, 2021
bors bot pushed a commit that referenced this pull request Feb 21, 2021
@benjamindavidson
feat(measure_theory/interval_integral): add simp attribute to `integr…
f470cc6 
…al_const` (#6334)

By adding a `simp` attribute to `interval_integral.integral_const`, the likes of the following become possible:
```
import measure_theory.interval_integral

example : ∫ x:ℝ in 5..19, (12:ℝ) = 168 := by norm_num
```
@bors
Copy link

bors bot commented Feb 21, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/interval_integral): add simp attribute to integral_const [Merged by Bors] - feat(measure_theory/interval_integral): add simp attribute to integral_const Feb 21, 2021
@bors bors bot closed this Feb 21, 2021
@benjamindavidson benjamindavidson mentioned this pull request Feb 22, 2021
Closed
@benjamindavidson benjamindavidson mentioned this pull request Mar 25, 2021
Closed
bors bot pushed a commit that referenced this pull request Mar 27, 2021
@benjamindavidson
feat(test/integration): add examples of computing integrals by simp (#…
879cb47 
…6859)

As suggested in [#6216 (comment)](#6216 (comment)).

The examples added here were made possible by #6216, #6334, #6357, #6597.
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@benjamindavidson @b-mehta
feat(measure_theory/interval_integral): add simp attribute to `integr…
00a8c3b 
…al_const` (#6334)

By adding a `simp` attribute to `interval_integral.integral_const`, the likes of the following become possible:
```
import measure_theory.interval_integral

example : ∫ x:ℝ in 5..19, (12:ℝ) = 168 := by norm_num
```
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@benjamindavidson @b-mehta
feat(test/integration): add examples of computing integrals by simp (#…
c0a3fb9 
…6859)

As suggested in [#6216 (comment)](#6216 (comment)).

The examples added here were made possible by #6216, #6334, #6357, #6597.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benjamindavidson @bryangingechen