Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/list/basic): repeat injectivity #6337

Closed
wants to merge 3 commits into from

Conversation

pechersky
Copy link
Collaborator


@pechersky pechersky added the awaiting-review The author would like community review of the PR label Feb 21, 2021
@@ -474,6 +474,35 @@ by cases n; refl
@[simp] theorem join_repeat_nil (n : ℕ) : join (repeat [] n) = @nil α :=
by induction n; [refl, simp only [*, repeat, join, append_nil]]

lemma repeat_inj_left {a b : α} {n : ℕ} (npos : 0 < n)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like *_left_inj and *_right_inj are more common in the library, and the example at our naming conventions page is sub_right_inj, so I'd recommend switching the naming over to that.

This convention might be confusing given all the other things named with left and right at the very end, but that's something we should discuss on Zulip if someone feels strongly about it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed lemmas, added function.injective versions, and golfed the proofs.

@bryangingechen
Copy link
Collaborator

Thanks! Feel free to merge if you're happy with Yury's changes.
bors d+

@bors
Copy link

bors bot commented Feb 21, 2021

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 21, 2021
@pechersky
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 22, 2021
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Feb 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/list/basic): repeat injectivity [Merged by Bors] - feat(data/list/basic): repeat injectivity Feb 22, 2021
@bors bors bot closed this Feb 22, 2021
@bors bors bot deleted the pechersky/repeat-inj branch February 22, 2021 03:13
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants