[Merged by Bors] - feat(data/finsum): sums over sets and types with no finiteness hypotheses #6355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
reviewed
Feb 22, 2021
digama0
reviewed
Feb 22, 2021
digama0
reviewed
Feb 22, 2021
eric-wieser
reviewed
Mar 30, 2021
Comment on lines
359
to
366
| /-- A more general version of `finprod_mem_hom` that requires `s ∩ mul_support f` and instead of | ||
| `s` to be finite. -/ | ||
| @[to_additive] lemma finprod_mem_hom' {f : α → M} (g : M →* N) (h₀ : (s ∩ mul_support f).finite) : | ||
| ∏ᶠ i ∈ s, (g (f i)) = g (∏ᶠ j ∈ s, f j) := | ||
| begin | ||
| rw [finprod_mem_def, mul_indicator_comp_of_one g.map_one, finprod_hom, finprod_mem_def], | ||
| rwa mul_support_mul_indicator | ||
| end |
There was a problem hiding this comment.
For finset.prod we call this monoid_hom.map_prod and flip the direction of the equality. I think it would make sense to do the same thing here, and call it monoid_hom.map_finprod_mem'?
eric-wieser
reviewed
Mar 30, 2021
bryangingechen
added
awaiting-author
github-actions
bot
removed
the
merge-conflict
urkud
added
awaiting-review
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
This will help us add `finprod` in #6355
eric-wieser
reviewed
Apr 2, 2021
semorrison
reviewed
Apr 5, 2021
semorrison
reviewed
Apr 5, 2021
semorrison
reviewed
Apr 5, 2021
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
semorrison
reviewed
Apr 6, 2021
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2021
…eses (#6355) This rather large PR is mostly work of Jason KY. It is all an API for `finsum` and `finsum_in`, sums over sets with no finiteness assumption, and which return zero if the sum is infinite. Co-authored-by: Kexing <kexing.ying19@imperial.ac.uk>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rather large PR is mostly work of Jason KY. It is all an API for
finsumandfinsum_in, sums over sets with no finiteness assumption, and which return zero if the sum is infinite.function.mul_support#6791 multiplicative support