New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(archive/100-theorems-list/9_area_of_a_circle): area of a disc #6374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamindavidson
added
the
awaiting-review
The author would like community review of the PR
label
Feb 23, 2021
fpvandoorn
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good! The proof is clean, and it is well-explained.
semorrison
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 24, 2021
benjamindavidson
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Feb 25, 2021
hrmacbeth
reviewed
Feb 25, 2021
bors merge |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 28, 2021
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2021
…6374) Freek № 9: The area of a disc with radius _r_ is _πr²_. Also included are an `of_le` version of [FTC-2 for the open set](https://leanprover-community.github.io/mathlib_docs/find/interval_integral.integral_eq_sub_of_has_deriv_at') and the definition `nnreal.pi`. Co-authored by @asouther4 and @jamesa9283. Co-authored-by: Andrew Souther <asouther@fordham.edu> Co-authored-by: Benjamin Davidson <68528197+benjamindavidson@users.noreply.github.com> Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(archive/100-theorems-list/9_area_of_a_circle): area of a disc
[Merged by Bors] - feat(archive/100-theorems-list/9_area_of_a_circle): area of a disc
Feb 28, 2021
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
…6374) Freek № 9: The area of a disc with radius _r_ is _πr²_. Also included are an `of_le` version of [FTC-2 for the open set](https://leanprover-community.github.io/mathlib_docs/find/interval_integral.integral_eq_sub_of_has_deriv_at') and the definition `nnreal.pi`. Co-authored by @asouther4 and @jamesa9283. Co-authored-by: Andrew Souther <asouther@fordham.edu> Co-authored-by: Benjamin Davidson <68528197+benjamindavidson@users.noreply.github.com> Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freek № 9: The area of a disc with radius r is πr².
Also included are an
of_le
version of FTC-2 for the open set and the definitionnnreal.pi
.Co-authored by @asouther4 and @jamesa9283.
n.b. We are forced to define the disc as a set of points in
ℝ × ℝ
and not viametric.ball
in Euclidean space as we ought to because of the current limitations ofmeasure_theory.pi
. See this conversation on Zulip.