[Merged by Bors] - feat(algebra/lie/cartan_subalgebra): define Cartan subalgebras #6385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
We do this via the normalizer of a Lie algebra, which is also defined here.
github-actions
bot
added
the
blocked-by-other-PR
ocfnash
added
the
awaiting-review
|
|
||
| ## Tags | ||
|
|
||
| lie subalgebra, normalizer, idealizer, cartan subalgebra |
There was a problem hiding this comment.
IMO Lie and Cartan should be uppercase here.
There was a problem hiding this comment.
I generally agree with capitalising names but I've been consistently sticking to pure lowercase for these Tags across 15+ files so I'm reluctant to make this file the odd one out!
Of course if someone wants to submit a PR capitalising all the names in Tags in src/algebra/lie/*.lean then that would be fine by me :-)
jcommelin
reviewed
Feb 23, 2021
github-actions
bot
added
merge-conflict
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
github-actions
bot
removed
the
merge-conflict
Co-authored-by: Johan Commelin <johan@commelin.net>
jcommelin
added
the
awaiting-author
The can be inferred from the (explicit) `lie_subalgebra` argument.
No functional change but perhaps helpful to a human
ocfnash
removed
the
awaiting-author
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2021
We do this via the normalizer of a Lie subalgebra, which is also defined here.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Mar 18, 2021
We do this via the normalizer of a Lie subalgebra, which is also defined here.
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
We do this via the normalizer of a Lie subalgebra, which is also defined here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this via the normalizer of a Lie subalgebra, which is also defined here.