-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(data/equiv/basic): lemmas about images and preimages #6398
Conversation
gebner
commented
Feb 24, 2021
@@ -353,6 +353,29 @@ protected lemma image_compl {α β} (f : equiv α β) (s : set α) : | |||
f '' sᶜ = (f '' s)ᶜ := | |||
set.image_compl_eq f.bijective | |||
|
|||
@[simp] lemma symm_preimage_preimage {α β} (e : α ≃ β) (s : set β) : | |||
e.symm ⁻¹' (e ⁻¹' s) = s := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a lemma that says f ⁻¹' (g ⁻¹' s) = (f \comp g) ⁻¹' s
or whatever variant of that is true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's called preimage_preimage
(as you would expect). That is, a few characters longer than the current proof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I ask only because simp
would solve this automatically if preimage_preimage
were marked simp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I'm not too happy to mark conditional simp lemmas as simp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what way is preimage_preimage
conditional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, I was looking at the wrong lemma. No, preimage_preimage
is indeed not conditional. But then I'm not so sure it's a good idea to mark it simp (because it prevents lemmas like bar (foo ⁻¹' X) ↔ baz X
from triggering).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you mean lemmas like bar ⁻¹' (foo ⁻¹' X) ↔ baz X
with ⁻¹'
twice? Do we have any of those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way, I guess its out of scope for this PR.
bors merge |
Pull request successfully merged into master. Build succeeded: |